search

IshaaanVyas / pe

0 stars 0 forks source link

Exception occurs when trying to use remove employee with invalid index #5

Open IshaaanVyas opened 2 years ago

IshaaanVyas commented 2 years ago

image.png

Trying to remove the 0th index causes error

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Removing invalid employee index

image.png

Index error.

Steps to replicate:

  1. Start game.
  2. Add employee. Command -> add-employee/john/12345678/perm/1
  3. remove employee with index 0. Command -> remove-employee/0

[original: nus-cs2113-AY2122S1/pe-interim#33] [original labels: severity.High type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: image.png

This cannot be low severity, the user cannot continue using this application after this and has to restart the whole application. This can happen very frequently whenever the user types in an index that he thought existed but doesn't. The user could also be wanting to enter index 9 but entered 0 instead since the keys are so close on a keyboard. It also causes major inconvenience to have to restart the application every time, especially considering the fact that all current data is not saved when this exception occurs.