search

Ishadijcks / Ishadijcks.github.io

PokéClicker
15 stars 32 forks source link

Made it (more) responsive #9

Closed EdieLemoine closed 7 years ago

EdieLemoine commented 8 years ago

Also tidied a lot of code which is why it says there are so many edits.

Ishadijcks commented 8 years ago

Can you explain how it is more responsive now?

EdieLemoine commented 8 years ago

It now scales properly on any size, mobile isn't perfect as the map doesn't scale up or down but on any size I tested (between mobile and 4K) the map container fits properly and doesn't leave empty space. Also I changed some padding/margins to all be the same size.

Ishadijcks commented 8 years ago

Yeah map will be fixed in a future update, where I make the overflow scrollable. Alright that's great! I really hadn't designed the interface with mobile and 4K in mind, but it's cool that that works now.

I'm gonna play with the width a little bit, because right now it's a tad too wide for my taste.

Thanks :)

Ishadijcks commented 8 years ago

I might have overlooked something, but where is the leftColumn getting its margin-left from?

EdieLemoine commented 8 years ago

What do you mean? Like how it's floating in the middle?

Ishadijcks commented 8 years ago

Ya

EdieLemoine commented 8 years ago

Because .container does that, you used .container-fluid before which is essentially a full-width container. This one floats in the middle, has a 100% width but a max-width of 1170px (or something) so it's fullwidth on anything smaller than its max-width.

Ishadijcks commented 8 years ago

Ooh yeah I get it.