search

IshentRas / cookbook-openshift3

Chef Cookbook for Openshift
https://supermarket.chef.io/cookbooks/cookbook-openshift3
MIT License
27 stars 12 forks source link

Support for Origin v3.6.0 #152

Closed jperville closed 6 years ago

jperville commented 7 years ago

With Openshift Origin v3.6.0 just released it is time to update this cookbook again.

Checklist (to be completed):

jperville commented 7 years ago

@ianmiell @IshentRas It seems that the Centos repository at http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin/ just got cleaned and that only RPMs for version 3.6.0 are present. We will have to update the cookbook for 3.6.x very soon or find use alternative repositories such as http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin15/

ianmiell commented 7 years ago

I have already made a change as part of the 157 work:

https://github.com/IshentRas/cookbook-openshift3/commit/f25b90821b4974c201507dfabcd96708838c8b47

On Wed, Sep 13, 2017 at 5:43 PM, Julien Pervillé notifications@github.com wrote:

@ianmiell https://github.com/ianmiell @IshentRas https://github.com/ishentras It seems that the Centos repository at http://mirror.centos.org/centos/7/paas/x86_64/openshift-origin/ just got cleaned and that only RPMs for version 3.6.0 are present. We will have to update the cookbook for 3.6.x very soon or find use alternative repositories such as http://mirror.centos.org/centos/7/paas/x86_64/ openshift-origin15/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-329227119, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczepvH4ks0U9iSgDVKjdGUvqx0rYCks5siAY1gaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

ianmiell commented 6 years ago

Hi Julien, Have you made any progress with this/need any help? Ian

jperville commented 6 years ago

Hello @ianmiell, I have not started anything yet but I have scheduled this issue for my upcoming sprint. I'll happily take your help!

IshentRas commented 6 years ago

@jperville @ianmiell Sorry for the delay here... So many things to do.. Anyway, we are up for it. Currently testing the code for regression shit and we should be ok today :-) Improve the code, faster running and better logic :+1:

jperville commented 6 years ago

I will be available here once finish with my current story (by Thursday or Friday)..

ianmiell commented 6 years ago

Hey - great news - my Jenkins tests are down while my server is being repaired, but I can run it manually on another server.

I need to update the tests to add 3.6. I'll try and do all this now.

On Tue, Oct 10, 2017 at 1:39 PM, Julien Pervillé notifications@github.com wrote:

I will be available here once finish with my current story (by Thursday or Friday)..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-335458968, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczc8yTWfv1unjnwZdqQzuisJkCmr-ks5sq2WagaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

ianmiell commented 6 years ago

Test running now.

http://jenkins.meirionconsulting.tk/job/cookbook-openshift3/job/v3.6/

On Tue, Oct 10, 2017 at 2:52 PM, Ian Miell ian.miell@gmail.com wrote:

Hey - great news - my Jenkins tests are down while my server is being repaired, but I can run it manually on another server.

I need to update the tests to add 3.6. I'll try and do all this now.

On Tue, Oct 10, 2017 at 1:39 PM, Julien Pervillé <notifications@github.com

wrote:

I will be available here once finish with my current story (by Thursday or Friday)..

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-335458968, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczc8yTWfv1unjnwZdqQzuisJkCmr-ks5sq2WagaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

IshentRas commented 6 years ago
jperville commented 6 years ago

If you have a bit of time @IshentRas , could you look what is needed to implement an openshift_deploy_logging LWRP?

As you know, in v3.5 the logging addon deploy instructions became ansible-only (compare v3.4 and v3.5 instructions).

I tried a few months ago using the v3.4.x instructions with an updated docker image version with no success (ran into permission errors on the elasticsearch indices), so I gave up and deployed the v1.4.2 image over a v1.5.1 openshift cluster.

jperville commented 6 years ago

@IshentRas we should now have enough to cut a release with 3.6.x support. Every feature from earlier version of the cookbook is now working with v3.6.0, with kitchen tests passing.

@ianmiell can you run the Jenkins tests on current master?

ianmiell commented 6 years ago

I tried a test but my server gave up.

My big server is back from repair now so I should be able to test soon.

On Tue, Oct 17, 2017 at 8:47 AM, Julien Pervillé notifications@github.com wrote:

@IshentRas https://github.com/ishentras we should now have enough to cut a release with 3.6.x support. Every feature from earlier version of the cookbook is now working with v3.6.0, with kitchen tests passing.

@ianmiell https://github.com/ianmiell can you run the Jenkins tests on current master?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-337147159, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczTrNPAQLsqY_TB1K06-4_6eMM06xks5stFuSgaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

jperville commented 6 years ago

I think we have tested the code enough and it seems to work. How about cutting a new release with the support for OSE 3.6.x? Thoughts @ianmiell @IshentRas ?

ianmiell commented 6 years ago

I'm in favour. The tests I was performing were the last ones anyway.

On Thu, Oct 19, 2017 at 9:06 AM, Julien Pervillé notifications@github.com wrote:

I think we have tested the code enough and it seems to work. How about cutting a new release with the support for OSE 3.6.x? Thoughts @ianmiell https://github.com/ianmiell @IshentRas https://github.com/ishentras ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-337831590, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczcsva73U6Ukg6K0FOKcWjjf_TGpIks5stwMTgaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell http://manning.com/miell/?a_aid=zwischenzugs&a_bid=e0d48f62

jperville commented 6 years ago

Attention: dnsmasq setup is broken when using current master (v3.6 support) when trying to deploy older versions of origin. See report in #170 . I fixed in PR #172 .

jperville commented 6 years ago

Now that #173 merged we should be ready to cut a new release (I'd like one since I am upgrading cluster to 3.6 tomorrow). @ishentras

IshentRas commented 6 years ago

@jperville Shit I did not realise I close this one as well... Would you like me to include it and push to master? Let me know, I have still got your reference file : https://github.com/PerfectMemory/cookbook-openshift3/blob/eefa23eb5487d854e67d1da9f2c0bbee98823b2a/test/inspec/shared/11_functioning_openshift_test.rb

jperville commented 6 years ago

Yes please include the test and push master.

ianmiell commented 6 years ago

I added a test for

host kubernetes.[etc]

I assume it should only resolve, and not necessarily route to it? That's what happened on 1.3.3.

On Sat, Oct 21, 2017 at 5:05 PM, Julien Pervillé notifications@github.com wrote:

Yes please include the test and push master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/IshentRas/cookbook-openshift3/issues/152#issuecomment-338412919, or mute the thread https://github.com/notifications/unsubscribe-auth/AGrczXZ7HYZFaNaw0rY_4hmJwwwBmiTpks5suhZRgaJpZM4OpuJm .

-- My book on Docker in Practice: Get 39% off with the code 39miell2 https://www.manning.com/books/docker-in-practice-second-edition?a_aid=zwischenzugs&a_bid=550032fc

IshentRas commented 6 years ago

@jperville @ianmiell Ok Just updated the metrics for 3.6.0 and all working fine. Lot of work.... But we are there finally. Next step. logging.

jperville commented 6 years ago

Btw, openshift 3.7 is released last week. Now that v1.10.66 of this cookbook has been release, I suggest closing this issue (we can make a separate one for logging LWRP support).