Ishi01 / CITS5505Group41Project

CITS5505 Agile Web Develoment Group Project
MIT License
1 stars 0 forks source link

integrate user login system with database #14

Closed berry1104 closed 6 months ago

berry1104 commented 6 months ago

add new features:

berry1104 commented 6 months ago

other changes

stuar7 commented 6 months ago

Looks good! The instructions for the database initialisation are a bit incorrect since if the migrations file already exists the process to initialise the database is: flask db migrate -> flask db upgrade. The init function doesn't have to be run again by any user pulling the repository.

I'm also considering that individuals should be able to use the world map game without logging in, just their performance data won't be saved or tracked.

I updated the .gitignore file to not push the database in 346770c.

berry1104 commented 6 months ago

thanks for the reviews, i will make these changes:

  1. remove the flask db init step
  2. temporarily remove the "requiring login" feature, as we might discuss when data should be stored tomorrow, like add a new endpoint(/.game) for enter "game mode" where users are required login and data will be store