search

IshitaTakeshi / lsd_slam_noros

ROS-independent implementation of LSD-SLAM
GNU General Public License v3.0
21 stars 7 forks source link

Remove docker image after exiting session #8

Closed adamjstewart closed 3 years ago

adamjstewart commented 3 years ago

Without this, if I launch a docker container and exit it, I can no longer re-run the launch script. I have to first kill the container.

IshitaTakeshi commented 3 years ago

I think this depends on the usage. For example if you want to edit the implementation of LSD-SLAM the container should not be destroyed.

adamjstewart commented 3 years ago

In that case maybe it would be good to add a section to the README explaining how to reconnect to a docker container that is already launched. I'm not very familiar with docker so I had a hard time with this.

IshitaTakeshi commented 3 years ago

Sure. Thank you for the suggestion

IshitaTakeshi commented 3 years ago

Added it for Linux. https://github.com/IshitaTakeshi/lsd_slam_noros/commit/67018269851708411dc168fd50159110c54c7b19