search

Ishmaeel / CrackbookRevival

Chrome extension for discouraging the use of attention-sucking websites
Other
33 stars 13 forks source link

Add options for text and background color for the dimmer popup. #7

Closed allenbenz closed 2 years ago

allenbenz commented 4 years ago

I use Dark Reader which inverts the color of the dimmer popup. So I added color parameters for the text and background of the popup.

This is a little raw and it might be better to have theme option instead, but doing that seemed presumptuous.

I will rework this once #3 is merged, provided you are interested.

color_config

Ishmaeel commented 4 years ago

I would be interested, but I was not able to reproduce the scenario where Dark Reader inverts the overlay itself. Are we talking about the same DR? Could you link the actual extension that you use and perhaps attach a screenshot?

BTW, I merged #3 now, which seems to have resulted in some conflicts.

allenbenz commented 4 years ago

It's Dark Reader.

After poking around, the issue manifests when the filter, filter+, or static theme engines are used. I don't use dynamic because it produces grey backgrounds instead of black for many of the sites I visit.