search

IshmaelBelghazi / ALI

Adversarially Learned Inference
MIT License
311 stars 80 forks source link

Discriminator input #6

Open anantzoid opened 7 years ago

anantzoid commented 7 years ago

In the paper, it's mentioned that the input of discriminator is either joint pairs of q(x\~,z) or p(x,z\^). However, in the code, it seems (z,z\^) and (x,x\~) are concatenated and being sent as input to z_discriminator and x_discriminator respectively.

There seems to be a discrepancy here. Please let me know if I'm missing something.

Thanks.

edgarriba commented 7 years ago

@anantzoid it's then split in https://github.com/IshmaelBelghazi/ALI/blob/master/ali/bricks.py#L50-L51 but yes, overall to me the theano code differs a bit from the described algorithm in the paper