search

Isidore-Guild / coverdale

OSIS Coverdale
Creative Commons Zero v1.0 Universal
1 stars 2 forks source link

div elements for type="book" should also have canonical="true" #5

Closed DavidHaslam closed 6 years ago

DavidHaslam commented 6 years ago

Refer to the OSIS Reference Manual for why this should be included.

OSIS2_1UserManual06March2006-_with_O'Donnell_edits.PDF

When canonical="true", it means that the content of that element is a part of the text being encoded. For example, the "text" of the Bible includes the content of books, chapters, and verses but does not include notes, section-headings added by editors or translators, etc. Therefore, the default value for elements such as note is false, as the content of that element has been added by an editor or author to the text being encoded. It should be explicitly noted that the value of the canonical attribute should not be used to reflect theological judgment about the content of a text, but merely to distinguish between what has been added to the text and what has not.

DavidHaslam commented 6 years ago

Alternatively, we could just add it to the osisText element, seeing as this attribute is inherited. Thus:

    <osisText osisRefWork="Bible" osisIDWork="Coverdale" xml:lang="en" canonical="true">
DavidHaslam commented 6 years ago

Fixed with my alternative proposal in merge request #8