search

Iskallia / MegaLoot

Minecraft Mod: Mega Loot
7 stars 5 forks source link

Not technically a bug but question! #3

Closed strikerrocker closed 6 years ago

strikerrocker commented 6 years ago

Would you accept my Pull Request on various things in this mod using deprecated thinks like not using json recipes and mot using registry events. If so i can sumbit a few pull request on these to improve the overall code quality. I wanted to make sure that i wouldnt waste time doing a PR which wouldn't be accepted. If no i have no problem.

WinterGrave commented 6 years ago

Hi, I'm already in the process of changing to json recipes on all my mods, but I'm open to any improvements, I thin I am using the registry events for items and blocks in the last push, although I had a little trouble detecting where and how to register tile entities :P if you can help on that I'd be ok with it, if there are any conflicts with the PR I will try to sort it as best as possible, I'm not a pro on git. Thanks!

strikerrocker commented 6 years ago

Tile entities are registered in block registry after you register the blocks associated with them.

strikerrocker commented 6 years ago

If you have anymore doubt here is an discord consisting of modders who can help with situations from starters to advanced modding : https://discord.gg/ZwyDK96 This is it for this issue thanks for taking my suggestions