search

Iskallia / Vault-public-S1

👾 (Legacy) A mod that adds the mystic vaults for Vault Hunters modpack. (Public port of the Livestream version)
GNU General Public License v3.0
84 stars 40 forks source link

CREATE smart pipe differentiates between health/regen potion fluid in bottles and potion fluid created in the CREATE basin. #974

Open Kulfyr3 opened 2 years ago

Kulfyr3 commented 2 years ago

Describe the bug For some reason, the smart pipe in CREATE, which can filter fluids, doesn't recognize the health/regen potion fluid created in the basin as equivalent to the fluid in bottles. This creates issues when trying to automate systems using CREATE. This isn't an issue with other kinds of potion fluid, or water, as far as i can tell, though i haven't tested everything. My guess is that it has something to do with the different recipes for these.

To Reproduce Steps to reproduce the behavior:

  1. Use only the CREATE basin and mixer to make health potion fluid in the basin.
  2. Manually fill a bottle with the potion in the basin
  3. Apply the bottle to a smart pipe's filter, connected to the basin
  4. Watch as the basin refuses to accept the liquid through.

PS: If you fill the basin with any potion liquid from a bottle, the filter works as expected. Some attribute of the fluid is seemingly changed when you do this, which lets the smart pipe recognize it.

Expected behavior As happens with every unmodified potion liquid, i would expect the smart pipe to let the health potion through.

Screenshots or Crash Report I've added a video showing the problem.

Info (please complete the following information):

https://user-images.githubusercontent.com/33559377/171922590-b81bea2c-8c6f-43e8-b876-b7b68e1f66b8.mp4

tobi-blackscale commented 2 years ago

The custom recipe is missing a tag. The create potion fluid <fluid:create:potion> uses tags to store potion data. on of the tags is "Bottle", which stores the kind of bottle the recipe produces when filled into a bottle. Possible values are: REGULAR, SPLASH, LINGERING; Without those, the spout defaults to REGULAR, but the automatic generated recipes and filters will not recognise the potion correctly.

This also prevents upgrading the healing potion to the strong healing potion, without bottling in between (emptying the bottle into a create machine will apply the correct tags).

To fix this, the custom recipe has to include the tag(s) (input(for upgrading) and output).

Recipe has to be in there three times (for each bottle type) as well, as the awkward potion can already have the lingering/splash effect.

tobi-blackscale commented 2 years ago

Probably also the cause for these two:

934

809

joshuaepstein commented 2 years ago

If you are having an issue with create, created an issue on their github: https://github.com/Creators-of-Create/Create/issues

Vault hunters dev team can't fix a mod that isn't theirs...

tobi-blackscale commented 2 years ago

This is not a create issue, this modpack is breaking create functionality by changing recipes. This modpack has to add the correct tags to the changed recipes, so the create mod can work with them. Not the other way around.

RSNFreud commented 2 years ago

This is fixed in latest version