search

Islandora-Collaboration-Group / ISLE-Drupal-Build-Tools

A set of scripts to spin up an Islandora instance; used for ISLE-apache.
GNU General Public License v3.0
2 stars 14 forks source link

Remove unsupported nodequeue. Errors kill the install scripts #17

Closed Digital-Grinnell closed 4 years ago

Digital-Grinnell commented 4 years ago

Last evening I tried spinning up a new 'local' ISLE, but the ISLE-Drupal-Build-Tools scripts failed with messages indicating that the Drupal nodequeue module was unstable and no longer supported. Checking drupal.org confirmed, that module is no longer supported, so there's no Composer package to download. This apparently caused drush to fail later in the scripts, and ultimately left me with no local ISLE.

I moved to a different Mac this morning and tried the same with a pristine 'demo' instance of ISLE... same errors, same result... no demo ISLE.

The fix I implemented was simple, it just comments out the one instance of nodequeue in this repo. I subsequently changed my local.env file to pull ISLE-Drupal-Build-Tools from my revised fork (and branch) like so:

# Repo and branch to pull?
# ISLE_BUILD_TOOLS_REPO=https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools.git
# ISLE_BUILD_TOOLS_BRANCH=7.x-1.13
ISLE_BUILD_TOOLS_REPO=https://github.com/Digital-Grinnell/ISLE-Drupal-Build-Tools.git
ISLE_BUILD_TOOLS_BRANCH=fix-nodequeue-error

That worked. With these changes in place I can successfully build a local ISLE again. I did NOT test this kind of change with 'demo' yet, but if this PR is accepted and merged no additional modifications should be necessary.

noahwsmith commented 4 years ago

I definitely support removing this from the build tools script.

bseeger commented 4 years ago

Closing as code was wrapped into https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools/pull/19