search

Islandora-Collaboration-Group / ISLE-Drupal-Build-Tools

A set of scripts to spin up an Islandora instance; used for ISLE-apache.
GNU General Public License v3.0
2 stars 14 forks source link

Re-fixing the 'nodequeue' removal. #19

Closed Digital-Grinnell closed 4 years ago

Digital-Grinnell commented 4 years ago

I brought back 'nodequeue' briefly to try and test some error response measures I introduced in the build scripts. Those measures did not work... my comments from Slack:

For what it’s worth, I could NOT find a way to easily stop the install process when the scripts encounter an ERROR. It seems the drush and make commands that occasionally issue an [Error] do not return a non-zero status. :white_frowning_face: So, there’s not an easy way to catch the errors and respond.

This PR wraps up the changes by reinstating the removal of 'nodequeue' from the Drupal modules list.

bseeger commented 4 years ago

Hi @McFateM - can you please move this off of your master branch? Should be easy to check out as a new branch.

bseeger commented 4 years ago

@McFateM - this PR looks like it wraps in the other two, right? https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools/pull/17 and https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools/pull/18

bseeger commented 4 years ago

(Sorry, didn't mean to close the PR)

bseeger commented 4 years ago

@McFateM - you may have to resubmit this PR after changing branches. I'm not sure though.

Digital-Grinnell commented 4 years ago

I've added issue #20 to the queue here and will "properly" create ONE new PR to address it per the comments here. Sorry for the confusion. I'm hoping I can just "Close and comment" to end this thread.