search

Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

Capture script elapsed time #129

Open McFateM opened 6 years ago

McFateM commented 6 years ago

Suggest wrapping some ‘date’ commands around some (maybe all) of the install scripts like this:

!/bin/bash

date # echo the date at start
...the script contents... date # echo the date at end

Gives the user a quick record of elapsed time to execute the script. In particular, I think isle_drupal_build_tools/isnstall_isle_ld_site.sh could benefit from this.

OR, better yet, modify the documentation (This enhancement also appears in the ISLE-Documentation issues queue) so that script execution is fronted with a 'time' command, like so...

> root@35bac072fbb3:/tmp/isle_drupal_build_tools# time ./install_isle_ld_site.sh
...
Drush script finished! ...exiting

real    7m8.249s
user    2m37.230s
sys 0m46.770s
root@35bac072fbb3:/tmp/isle_drupal_build_tools#
bseeger commented 5 years ago

Good idea - which way do folks want to go with this? And does 'time' slow any of the commands down? If so, then I'd advocate for this being in the docs, versus the scripts.

McFateM commented 5 years ago

I wondered about any performance hit too, and read this: https:/stackoverflow.com/questions/11838458/overhead-of-time-command-in-unix. In summary, it says there is no appreciable performance hit.

So, I prefix almost ALL of my CLI work with time. I find it helpful when comparing systems as well as different versions of scripts/processes.

-Mark M.

From: "B. Seeger" notifications@github.com<mailto:notifications@github.com> Reply-To: Islandora-Collaboration-Group/ISLE reply@reply.github.com<mailto:reply@reply.github.com> Date: Monday, March 25, 2019 at 9:10 AM To: Islandora-Collaboration-Group/ISLE ISLE@noreply.github.com<mailto:ISLE@noreply.github.com> Cc: Mark McFate mcfatem@grinnell.edu<mailto:mcfatem@grinnell.edu>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [Islandora-Collaboration-Group/ISLE] Capture script elapsed time (#129)

Good idea - which way do folks want to go with this? And does 'time' slow any of the commands down? If so, then I'd advocate for this being in the docs, versus the scripts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Islandora-2DCollaboration-2DGroup_ISLE_issues_129-23issuecomment-2D476213777&d=DwMCaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=PQglHQe-EzyZqJOuOVcmU0OZ6bg-89msSPuqyNlQr28&m=oEkegzwX5A12oHM-evd8eiqnk1X3zA15xfCZPa2CHiw&s=GlNBJeuFmKTkFU-pEv27090Kpj_eQz7gPes-VXDQ2Vg&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIFIwSmZX2yjrfdhfICtZ-5F86LMW8chFhks5vaNjXgaJpZM4SktIv&d=DwMCaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=PQglHQe-EzyZqJOuOVcmU0OZ6bg-89msSPuqyNlQr28&m=oEkegzwX5A12oHM-evd8eiqnk1X3zA15xfCZPa2CHiw&s=3V7HZhzGgW9xgmK04_tOH-HS-FHFOQmIJIRidWIHPgQ&e=.

dwk2 commented 5 years ago

Great suggestion Mark! Since there's little appreciable performance hit, I'd prefer to see time processing output put into the Code, rather than the Docs. I think all installations would benefit from this, and I'd like to keep the documentation as minimal and clean as possible.

David Keiser-Clark

On Mon, Mar 25, 2019 at 10:15 AM Mark McFate notifications@github.com wrote:

I wondered about any performance hit too, and read this: https:/ stackoverflow.com/questions/11838458/overhead-of-time-command-in-unix. In summary, it says there is no appreciable performance hit.

So, I prefix almost ALL of my CLI work with time. I find it helpful when comparing systems as well as different versions of scripts/processes.

-Mark M.

From: "B. Seeger" <notifications@github.com<mailto: notifications@github.com>> Reply-To: Islandora-Collaboration-Group/ISLE <reply@reply.github.com mailto:reply@reply.github.com> Date: Monday, March 25, 2019 at 9:10 AM To: Islandora-Collaboration-Group/ISLE <ISLE@noreply.github.com<mailto: ISLE@noreply.github.com>> Cc: Mark McFate mcfatem@grinnell.edu<mailto:mcfatem@grinnell.edu>, Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [Islandora-Collaboration-Group/ISLE] Capture script elapsed time (#129)

Good idea - which way do folks want to go with this? And does 'time' slow any of the commands down? If so, then I'd advocate for this being in the docs, versus the scripts.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Islandora-2DCollaboration-2DGroup_ISLE_issues_129-23issuecomment-2D476213777&d=DwMCaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=PQglHQe-EzyZqJOuOVcmU0OZ6bg-89msSPuqyNlQr28&m=oEkegzwX5A12oHM-evd8eiqnk1X3zA15xfCZPa2CHiw&s=GlNBJeuFmKTkFU-pEv27090Kpj_eQz7gPes-VXDQ2Vg&e=>, or mute the thread< https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AIFIwSmZX2yjrfdhfICtZ-5F86LMW8chFhks5vaNjXgaJpZM4SktIv&d=DwMCaQ&c=HUrdOLg_tCr0UMeDjWLBOM9lLDRpsndbROGxEKQRFzk&r=PQglHQe-EzyZqJOuOVcmU0OZ6bg-89msSPuqyNlQr28&m=oEkegzwX5A12oHM-evd8eiqnk1X3zA15xfCZPa2CHiw&s=3V7HZhzGgW9xgmK04_tOH-HS-FHFOQmIJIRidWIHPgQ&e=

.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Islandora-Collaboration-Group/ISLE/issues/129#issuecomment-476215827, or mute the thread https://github.com/notifications/unsubscribe-auth/ADME33agU7hl72v5qjEYpWkez5PVcLy-ks5vaNoKgaJpZM4SktIv .