Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

Add the ability to pull isle_drupal_build_tools from any repository, and branch #161

Open br2490 opened 6 years ago

br2490 commented 6 years ago

Please add an environment variable that permits users to

br2490 commented 6 years ago

In development build, commit: https://github.com/Islandora-Collaboration-Group/isle-apache/commit/930f43c8b6a2409250d812f030696d4659cac33b

br2490 commented 6 years ago

Variables added: PULL_ISLE_BUILD_TOOLS = bool (true|false), default: true ISLE_BUILD_TOOLS_REPO = string, default: https://github.com/Islandora-Collaboration-Group/isle_drupal_build_tools.git ISLE_BUILD_TOOLS_BRANCH = string, default: master

g7morris commented 6 years ago

@br2490 Will you or @marksandford document how an enduser can change the ISLE_BUILD_TOOLS_REPO variable settings?

There is a lot more to this than simply changing a git URL right?

Reviewing the current README for https://github.com/Islandora-Collaboration-Group/ISLE-Drupal-Build-Tools does not give any indication how an enduser is supposed to use this repository so this feature may not be easily adopted?

Don't get me wrong, I like what everyone has done here and what has been gathered so far however this looks like a potential "last mile" documentation issue too.

Assuming steps are similar to:

[EDIT] @br2490 Okay so this variable /change is called here? https://github.com/Islandora-Collaboration-Group/isle-apache/pull/1/commits/7511ae4c80b6226d3972f6349f45d6ece042fbf2#diff-d05c1c2d65ed8806ae9c095e1c10af74

So this is a multi prong to do then?