Closed g7morris closed 6 years ago
Thank you for the fix however for testers it would be appreciated if a next steps response would be posted when necessary. In this case, I think for those getting onboarded with ISLE, they'd potentially need it.
In this instance, would it be fair to assume I need to first:
docker-compose stop
to stop all running containers
delete my current containers, docker rm isle-mysql-id
etc
docker pull
the isle-mysql
image
docker-compose up -d
Resume testing for this situation and confirming that the issue has ceased. If resolved, leave the ticket closed, if not reopen.
Hey @g7morris I'm nearing the final few updates for this. Thank you again for reporting all of these issues #162 #163 #164! I realize you're right that we're missing some docs on "How to Update" which would list the commands to update the images and restart updated containers && "Testing: Steps to take a maintainer pushes a development update to resolve issues during testing phases." I was wondering if you wouldn't mind creating an issue for that with the DOCS tag? you can of course assign: @marksandford and @br2490 When I'm done here with #162 I'll pop instructions in here for how to fetch this update!
Thank you for testing and reporting issues (and everything else you do for us!), Gavin!! 💯
This is resolved but may reveal an additional issue: @g7morris To test this update there several options:
Please use this method if you can to verify if the util scripts are being updated:
Restart the apache container docker restart isle-apache-ld
(Assuming CONTAINER_SHORT_ID
in the .env file is ld
if not, replace appropriate env value. This should pull the latest build tools on start. In my own testing this did not happen.
To check if build_tools are being updated:
docker exec -it isle-apache-ld bash
(assuming CONTAINER_SHORT_ID
)cd /utility-scripts/isle_drupal_build_tools && git rev-parse --short HEAD
f59fb4c
git fetch --all && git reset origin/master --hard
Start fresh docker-compose down -v
and docker-compose up -d
then run the installer.
@br2490 Confirming I followed your steps above and found the value of f59fb4c
as requested. There was no need to follow the steps beyond that point.
From the Status report now, it appears that Error 3 has been fixed and as such is not being reported any more.
However Error 1 and Error 2 are still occurring.
Should I restart testing from scratch at this point and confirm if errors still occur? No problem to do so.
Thank you for confirming the update script for install script works! In my original steps I failed to mention: please re-run the install script on isle-apache after the update! I've copied this from the quickstart guide: docker exec -it isle-apache-ld bash /utility-scripts/isle_drupal_build_tools/isle_islandora_installer.sh
Benjamin Rosner
Instructional Application Developer Instructional Media and Technology, Barnard Library and Academic Information Services p: 212-854-9005
On Mon, Sep 17, 2018 at 11:17 AM Gavin Morris notifications@github.com wrote:
@br2490 https://github.com/br2490 Confirming I followed your steps above and found the value of f59fb4c as requested. There was no need to follow the steps beyond that point.
From the Status report now, it appears that Error 3 has been fixed and as such is not being reported any more.
However Error 1 and Error 2 are still occurring.
[image: screen shot 2018-09-17 at 11 13 39] https://user-images.githubusercontent.com/501554/45632228-d05f3400-ba6a-11e8-82d5-4cb0b305aa19.png
Should I restart testing from scratch at this point and confirm if errors still occur? No problem to do so.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Islandora-Collaboration-Group/ISLE/issues/162#issuecomment-422056236, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhlbJYgIWX_qK3zEMJoBemn_4EZv7i0ks5ub7z_gaJpZM4Wp76A .
@br2490 With respect to Error 1 this was a setting present in ISLE v.10
https://github.com/Islandora-Collaboration-Group/ISLE/blob/ISLE-v1.0/mysql/my.cnf
lines 94 and 95
Possible to review and put them back in please?
MySQL was updated to 5.7 and the my.cnf from ISLE 1 was actually ported
directly (why replace something that works?)
Later it was found that the conf file was actually not being parsed (hence
the errors) as it had invalid settings for MySQL 5.7. The MySQL container
was updated and when you ran docker-compose pull
this AM (for the other
updates) it will have grabbed the new image with settings.
To review the current settings in My5.7 checkout the github repo
https://github.com/Islandora-Collaboration-Group/isle-mysql and report back
if you notice anything missing, please! (check in the rootfs folder.)
Benjamin Rosner
Instructional Application Developer Instructional Media and Technology, Barnard Library and Academic Information Services p: 212-854-9005
On Mon, Sep 17, 2018 at 11:27 AM Gavin Morris notifications@github.com wrote:
@br2490 https://github.com/br2490 With respect to Error 1 this was a setting present in ISLE v.10
https://github.com/Islandora-Collaboration-Group/ISLE/blob/ISLE-v1.0/mysql/my.cnf
lines 94 and 95
Possible to review and put them back in please?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Islandora-Collaboration-Group/ISLE/issues/162#issuecomment-422060594, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhlbJDFsudVJaWautsgvaR0_BpzH1PAks5ub792gaJpZM4Wp76A .
@br2490 Indeed! Upon the complete site rebuild, confirming all green on Drupal Status Reports! Thanks very much. Closing ticket.
Issue description
Having created a New ISLE site following the instructions here https://islandora-collaboration-group.github.io/ISLE-Documentation/03_installation_new_site/new_site_installation_guide_single/, I've logged into my new Drupal site as the admin, navigated the
Status Report
section https://islandora-docker.com/node#overlay=admin/reports/status, and noticed multiple errors and/or warnings.Steps to reproduce the issue
What's the expected result?
What's the actual result?
- Error 1:
(In blue)
This should be enabled. I believe this was not an error prior and more than likely can be resolved during the build process of the mysql image. Recommend ISLE Maintainers review https://www.drupal.org/node/2754539 for appropriate fixes.
- Error 2:
(In red)
I'm not sure what the issue here is per se and recommend an ISLE maintainer review and test. Simply reporting.
- Error 3:
(in yellow)
Not sure what happened here but indeed it should be 16M or higher.
Additional details / screenshot