search

Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

Staging install instructions: clarify or improve "commit locally to git" #365

Closed bondjimbond closed 3 years ago

bondjimbond commented 4 years ago

Issue description

At the "Edit the '.env' file" stage of the installation instructions, we are told:

You'll need to add this file and commit it in git to be able to get future updates from ISLE as a process.

git add .env git commit -m "Added the edited .env configuration file for Staging. DO NOT PUSH BACK TO UPSTREAM REPOSITORY - Jane Doe 8/2019" This is a suggested warning for users NOT TO push back this configuration change to the main git repository. If that were done it could conflict with other setups.

Following these instructions does not actually prevent .env from being pushed back; should we not simply be adding it to .gitignore instead?

g7morris commented 4 years ago

@bondjimbond You are 100% correct in questioning this and in identifying the proper method. I believe this process was to be included in an upcoming release. I'll make note of this and discuss with the team. Thank you.

g7morris commented 3 years ago

Closing as "fixed" from ISLE 1.5.5 release