Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

Documentation update: docs/update/update.md needs "master" changed to "main" #409

Closed SummittDweller closed 3 years ago

SummittDweller commented 3 years ago

Issue description

This is a documentation change required in docs/update/update.md, and maybe elsewhere?

I'm working through the aforementioned document to update my dg.localdomain instance of ISLE from v1.5.3 to v1.5.4 and found what I believe is a problem with lines 36 and 37. Those read:

However, it appears that proper branch name is now main, not master, so explicitly pulling the master branch does not update as expected.

It looks like the branch naming was changed from master to main to follow-up with Github's change in mid-2020, but not all of the documentation references to master were changed to main? This one seems particularly important since without such a change the procedure won't accomplish what's intended.

Thanks for making the change in branch names in the first place!

g7morris commented 3 years ago

Hi @marksandford or @dwk2

Is this something that the Documentation team could pick up for the upcoming ISLE release?

Thanks, Gavin

dwk2 commented 3 years ago

Yes, I'll take care of it. David

On Wed, Mar 10, 2021 at 12:33 PM Gavin Morris notifications@github.com wrote:

Hi @marksandford https://github.com/marksandford or @dwk2 https://github.com/dwk2

Is this something that the Documentation team could pick up for the upcoming ISLE release?

Thanks, Gavin

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Islandora-Collaboration-Group/ISLE/issues/409#issuecomment-795788974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZQJX3KGSOBI3ZVAKQDIW3TC6NN7ANCNFSM4YJDPZWA .

dwk2 commented 3 years ago

This is completed. Please see https://github.com/Islandora-Collaboration-Group/ISLE/pull/412