search

Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

ISLE-v.1.5.5 Release - GA & Sec updates, software upgrades, release fixes #417

Closed g7morris closed 3 years ago

g7morris commented 3 years ago

Reference https://github.com/Islandora-Collaboration-Group/ISLE/projects/5

g7morris commented 3 years ago

Good morning @marksandford & @dwk2 Just an update that I'm getting through the ISLE 1.5.5 release which you can see here https://github.com/Islandora-Collaboration-Group/ISLE/pull/417/files The main takeaway is that per David's ticket here https://github.com/Islandora-Collaboration-Group/ISLE/issues/217 I took it as a branding change. isle.localdomain is now isle-demo.localdomain which is much clearer in my opinion. Also ISLE demo containers won't be using the opaque ld suffix but demo instead so isle-apache-demo instead of isle-apache-ld. ISLE user locals can continue to use ld and Circle-ci will still use td for testing. To this end, I've updated all documentation, READMEs and am working on getting all ancillary hard-coded scripts to understand with testing in Circle-ci. Would love if you both could please double-check my work prior to this going to the presses? You can review the progress in the Files Changed tab above. I'm just commenting here to ensure that this matches your vision on the changes as well. Please let me know if I'm heading in the wrong direction or if I should continue. Thanks!

g7morris commented 3 years ago

Okay so after reviewing with @noahwsmith offline and in the comments, I'm going to revert changes stemming from https://github.com/Islandora-Collaboration-Group/ISLE/issues/217 On the face of it, this was a good request @dwk2 but it appears to break too much for current ISLE users and tests. I think given we're in maintenance mode, we should label this as a can't fix despite the good intentions and thinking behind it. Sorry.

dwk2 commented 3 years ago

Thank you for the careful analysis and I'm okay with these changes being reverted.