Islandora-Collaboration-Group / ISLE

Islandora Enterprise (ISLE) is a community project that addresses two of the most significant pain-points in Islandora: installation and maintenance.
https://Islandora-Collaboration-Group.github.io/ISLE/
GNU General Public License v3.0
32 stars 34 forks source link

Corrected ambiguous issue in toml file that led to user error #429

Closed dwk2 closed 3 years ago

dwk2 commented 3 years ago

This is only for live Commercial SSL Certificates:

The Staging and Production New and Migrate documentation pages show an example that appears to instruct the user to uncomment 4 lines. However, uncommenting the first of those 4 lines ([entryPoints.https.tls]) causes the Traefik container to immediately exit upon docker-compose up -d.

The solution is to remove that one offending line of example code: [entryPoints.https.tls]

This PR removes that line of code from both the config/proxy/traefik.production.toml and config/proxy/traefik.staging.toml files, as well as the four related documentation files.

NOTE: On my Windows10 box, I ran dos2unix on these 6 files, but GIT is still complaining that line endings will be changed. So YOU may want to re-run dos2unix.exe on these 6 files to ensure UNIX line endings. Git is showing this message on my local when I committed these to this branch:

$ git add .
warning: LF will be replaced by CRLF in config/proxy/traefik.production.toml.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in config/proxy/traefik.staging.toml.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in docs/install/install-production-migrate.md.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in docs/install/install-production-new.md.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in docs/install/install-staging-migrate.md.
The file will have its original line endings in your working directory
warning: LF will be replaced by CRLF in docs/install/install-staging-new.md.
The file will have its original line endings in your working directory