Islandora-Collaboration-Group / icg_csv_import

CSV Import utility
0 stars 10 forks source link

Error Checking Improvements #18

Closed McFateM closed 8 years ago

McFateM commented 8 years ago

Xpath errors detected indide the batch CSV process are problematic as nearly all errors lead to AJAX failure and report themselves with misleading messages. Paths in the CSV header should be pre-checked before the batch process loop in order to avoid this, and to improve system performance.

McFateM commented 8 years ago

I introduced a new function, icg_csv_import_header_errors, yesterday and it appears to be working properly. From the function header...

/**

I will close this issue as soon as I have removed the redundant header/xpath checking from the icg_csv_import_batch_item function.

McFateM commented 8 years ago

Redundant header/xpath checking has been removed from icg_csv_import_batch_item and is now provided by the hook_validate_csv_header function found in icg_hooks/icg_hooks.module (and potentially in your own hook). Closing this issue.