Islandora-Collaboration-Group / islandora_webform

islandora_webform
GNU General Public License v3.0
6 stars 8 forks source link

Islandora Webform with 7.x-dev #21

Closed uconnjeustis closed 8 years ago

uconnjeustis commented 8 years ago

At the Islandora camp CT, I learned about this module and wanted to play around with it. For the camp, I installed the vm using the instructions from http://islandora-labs.github.io/islandora/install/README/ which installs the 7.x-dev version of Islandora; this is the latest release but gets this version name of dev instead of 7.x.1-5. When trying to enable Islandora webforms, it failed because it requires 7.x.1-5. Would it be possible to have this work with 7.x whether it be the dev with the vm or 7.x.1-5 and above?

patdunlavey commented 8 years ago

Hmm... hadn't anticipated that! The critical piece of islandora that needs to be version 7.1.5 or greater is the objective_forms module. I have no idea if the 7.x-dev vm you're using includes the updates that islandora webform needs. You could try disabling this requirements check in the islandora_webform.install file and see if it works. To do that, comment out 'islandora' in line 81:

      $tests = array(
     //   'islandora' => '7.x-1.5',
        'webform' => '7.x-4.10',
      );
patdunlavey commented 8 years ago

Oh! I just noticed that the vm at the url you referred to is the 7.x-2.x version of Islandora, which is in very heavy development. Islandora Webform almost certainly will not work with that version (I have not tried it though).

I would suggest for these purposes that the 7.x-1.5 version of the vm is the best one to use. The download link can be found here: http://islandora.ca/downloads.

uconnjeustis commented 8 years ago

Thanks Pat. I hope to get a test site at work that is 7.x.1-5 where I can get this tested. Though the link should lead to 7.x.1-5 and not 7.x.2. I'll also try commented out those lines and see if that works.

Jennifer

On Thu, Oct 22, 2015 at 9:35 PM, Pat Dunlavey notifications@github.com wrote:

Oh! I just noticed that the vm at the url you referred to is the 7.x-2.x version of Islandora, which is in very heavy development. Islandora Webform almost certainly will not work with that version (I have not tried it though).

I would suggest for these purposes that the 7.1.5 version of the vm is the best one to use. The download link can be found here: http://islandora.ca/downloads.

— Reply to this email directly or view it on GitHub https://github.com/commonmedia/islandora_webform/issues/21#issuecomment-150403256 .

uconnjeustis commented 8 years ago

Pat,

I commented out that line and it worked fine with the vm that I have! I'll begin playing around with it. Thanks for writing this. Jennifer

On Fri, Oct 23, 2015 at 2:17 PM, Jennifer Eustis uconnjeustis@gmail.com wrote:

Thanks Pat. I hope to get a test site at work that is 7.x.1-5 where I can get this tested. Though the link should lead to 7.x.1-5 and not 7.x.2. I'll also try commented out those lines and see if that works.

Jennifer

On Thu, Oct 22, 2015 at 9:35 PM, Pat Dunlavey notifications@github.com wrote:

Oh! I just noticed that the vm at the url you referred to is the 7.x-2.x version of Islandora, which is in very heavy development. Islandora Webform almost certainly will not work with that version (I have not tried it though).

I would suggest for these purposes that the 7.1.5 version of the vm is the best one to use. The download link can be found here: http://islandora.ca/downloads.

— Reply to this email directly or view it on GitHub https://github.com/commonmedia/islandora_webform/issues/21#issuecomment-150403256 .

ghost commented 8 years ago

I ran into this same problem with the Islandora Vagrant instance. I will try commenting out line 81 and report back.

ghost commented 8 years ago

I commented out line 81 and it was enabled in Islandora Vagrant instance

uconnjeustis commented 8 years ago

I did the same thing and the problem was solved as well.

Jennifer

On Thu, Dec 10, 2015 at 5:07 PM, Phil notifications@github.com wrote:

I commented out line 81 and it was enabled in Islandora Vagrant instance

— Reply to this email directly or view it on GitHub https://github.com/commonmedia/islandora_webform/issues/21#issuecomment-163763395 .

patdunlavey commented 8 years ago

I'm going to mark this as "won't fix". I can't recommend the solution that a couple comments suggested - of disabling the Islandora version check. Islandora webform ingest depends on the 7.x-1.5+ version of the objective form module.