search

Islandora-Collaboration-Group / islandora_webform

islandora_webform
GNU General Public License v3.0
6 stars 8 forks source link

Issue 23: Fixes submit when for Mult. Associations #26

Closed DiegoPino closed 8 years ago

DiegoPino commented 8 years ago

See #23. Also includes previous changes for #14 since they are dependant.

Tags where not being saved, even when correctly appended because the submit functions was iterating over all associations for a DSID. Since the use case involved a very different FORM, that had fields not present in all others, data was not being passed to the XML document. Also basic cleanup of iwi_set_form_element_byhash() was done to match for tag the exact logic of taband this way allow better understanding.

Finally includes all changes to allow a exact targeting of a non numeric index special element, like tab or tag, even nested.

patdunlavey commented 8 years ago

I've merged this locally and will test over the next day or so. Thanks so much for your efforts on this!

I believe this pull request supersedes https://github.com/commonmedia/islandora_webform/pull/18, so that one should be closed. Is that right @DiegoPino ?

DiegoPino commented 8 years ago

Right, closing #18 and linking to this. Thanks!