search

Islandora-Collaboration-Group / islandora_webform

islandora_webform
GNU General Public License v3.0
6 stars 8 forks source link

islandora_webform issue #23 #28

Closed patdunlavey closed 8 years ago

patdunlavey commented 8 years ago

See issue #23. There are a lot of threads that are hard to follow. I want to get this merged so we can all be working from the same code.

Basically, this extends on this pull request: https://github.com/commonmedia/islandora_webform/pull/26, fixing a couple minor bugs and providing api documentation of hook_iwi_set_form_alter().

patdunlavey commented 8 years ago

@DiegoPino any thoughts on merging this pull request?

DiegoPino commented 8 years ago

@patdunlavey, just for clarity, why not make individual pulls? It's difficult to see how all this interact, and also by being a merge from your master, all the history gets lost or not?

patdunlavey commented 8 years ago

@DiegoPino that would be better, but I'm not sure how to go back and tease this apart into independent pull requests that could stand on their own.

patdunlavey commented 8 years ago

Accepting this pull request will: resolve #14 resolve #27

DiegoPino commented 8 years ago

@patdunlavey, fine for me. Thanks