Islandora-Collaboration-Group / islandora_webform

islandora_webform
GNU General Public License v3.0
6 stars 8 forks source link

Unable to install IW on Islandora Vagrant - HEAD modules #29

Closed petermacdonald closed 8 years ago

petermacdonald commented 8 years ago

I'm using the Vagrant image of Islandora distributed with the 7.1.6 Islandora modules.

I upgraded all the modules to HEAD (7.x-dev), installed and enabled webform and webform_ajax, but whenI tried to enable the IW module using Drush I get this error message:

"Module islandora_webform doesn't meet the requirements to be enabled.[error] islandora_webform requires that islandora be at least version 7.x-1.5[error](Currently using islandora 7.x-dev)"

I tried enabling it using the Drupal > Modules menu and got a similar error message:

"islandora_webform requires that islandora be at least version 7.x-1.5 (Currently using islandora 7.x-dev)"

Is there anything I can do to get IW installed while using Islandora HEAD modules?

Thanks Peter

patdunlavey commented 8 years ago

Hi Peter, Can you try this patch? islandora_webform-issues-29-1.patch.txt

petermacdonald commented 8 years ago

I had already changed "7.1.5" to "7.x-dev" in the IW code which got me in just fine. But I'd really like to apply your patch, but, alas, I don't now how to apply a patch.

Sorry to have to ask, but how do I apply/run this patch?

patdunlavey commented 8 years ago
  1. Copy the file to path/to/islandora_webform
  2. Move to that directory if you aren't there already.
  3. Run the command patch -p1 < islandora_webform-issues-29-1.patch.txt

You might need to revert your change to get the patch to apply without errors. The only difference with what you did is that it should work for both 7.x-dev and 7.1.5+ numbered versions.

petermacdonald commented 8 years ago

Pat:

Running that command resulted in this message:

-jailshell: islandora_webform-issues-29-1.patch.txt: No such file or directory

Peter

petermacdonald commented 8 years ago

I manually moved the patched code from the patch file to the .install file and the Drupal installed it without a problem with Islandroa HEAD modules.

Peter

petermacdonald commented 8 years ago

[Using Islandora HEAD modules and IW cloned today 2016-02-02.]

On the Islandora site where I have configured two Webforms, all anonymous users (not an administrator) now see the following red error message at the top of Drupal's content window on all pages:

X - No fedora object PID was defined.

That message is coming from the islandora_webform_module, line 228.

I'll try to get rid of it if you have any ideas for me to try. Thanks.

See screen capture attached.

webform-error

patdunlavey commented 8 years ago

Re-opening this issue pending resolution of #30

patdunlavey commented 8 years ago

Pull request #31 merged.