Islandora-Devops / islandora-playbook

Ansible playbook for building Islandora
MIT License
31 stars 53 forks source link

Fix broken update process from all-in-one #204

Closed alxp closed 3 years ago

alxp commented 3 years ago

GitHub Issue: (link)

What does this Pull Request do?

Follow up to the discussion after the merge of #201 , which was failing if you had an existing site. The playbook would halt on composer require because the lock file had older versions of packages and the one-at-a-time update process was unable to complete.

What's new?

This change removes explicit references to composer packages that are already listed as requirements by islandora or islandora_defaults.

It also puts the three packages islandora/islandora_defaults, islandoar/openseadragon and islandora/controlled_access_terms onto one line in the required package list, this is valid and makes composer update them all at once so that a hanging version specification in the lock file doesn't hold it up.

How should this be tested?

Given a playbook that was built prior to the #201 changes , run 'vagrant provision' and observe the full run and that all Islandora packages are now at the 2.x branches.

Additional Notes:

Successfully tested both the test above and a clean run.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers @whikloj @seth-shaw-unlv @rosiel

rosiel commented 3 years ago

Tested, and it works. :D As a co-worker, I can't merge.

seth-shaw-unlv commented 3 years ago

@whikloj , can we get you to test? I still don't have a working VirtualBox. 😕

rosiel commented 3 years ago

Since I've tested, I can approve but can't merge because of the same institution policy.

whikloj commented 3 years ago

Building a pre- #203 box to test with