Islandora-Devops / islandora-playbook

Ansible playbook for building Islandora

MIT License

31 stars 53 forks source link

no-pdfjs #235

Closed rosiel closed 1 year ago

rosiel commented 1 year ago

GitHub Issue: (link)

What does this Pull Request do?

Now that both the Install Profile and the Starter Site include pdf.js in their composer.json, we don't have to install it in the playbook.

What's new?

Don't install pdfjs
Does this change require documentation to be updated? no
Does this change add any new dependencies? no
Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)? no
Could this change impact execution of existing code? no

How should this be tested?

Spin up a site using starter or starter_dev, and test if pdfjs works. Spin up a site using the install profile, and test if pdfjs works.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora-Devops/committers