search

Islandora-Devops / islandora-starter-site

A Drupal site demonstrating Islandora features. Use it as a starting point for customization.
https://sandbox.islandora.ca
GNU General Public License v2.0
4 stars 16 forks source link

README needs clarification about db connection config #127

Open Natkeeran opened 5 months ago

Natkeeran commented 5 months ago

In the README-> Usage -> 3rd step, it is not clear where we should have configured the database connection info. Should it be specified in the https://github.com/Islandora-Devops/islandora-starter-site/blob/main/assets/patches/default_settings.txt ?

In the Known issues section, it seems the db info gets passed as a parameter.

Please clarify how/where to specify the db connection info when manually installing this site.

rosiel commented 5 months ago

I agree.

From the looks of ISLE-DC, there's a step right before the drush site-install where the settings.php file is updated.

https://github.com/Islandora-Devops/isle-dc/blob/development/Makefile#L562-L565 https://github.com/Islandora-Devops/isle-buildkit/blob/main/drupal/rootfs/etc/islandora/utilities.sh#L384-L406

The starter site was designed to be in version control so it is probably the wrong place to store passwords like this. Rather, whatever script you use to install your system should provision those values. Also they will depend on your instance and the starter site is designed to be installable on any infrastructure. So I wouldn't store them in default_settings.txt.