Islandora-Devops / islandora-starter-site

A Drupal site demonstrating Islandora features. Use it as a starting point for customization.
https://sandbox.islandora.ca
GNU General Public License v2.0
3 stars 17 forks source link

Improve "Missing Media" views (Open Meeting Mar 2024) #139

Closed rosiel closed 5 months ago

rosiel commented 6 months ago

Following the "Views" session at the March 2024 open meeting, we realized the Missing Media views were missing filenames in the Data exports, as well they did not use batch processing (but should for scaling).

This PR adds those. And also a missing pager.

Thanks @aOelschlager and team (sorry I forgot who else was in the room and contributing!)

aOelschlager commented 5 months ago

Suggested edit:

diff --git a/config/sync/views.view.missing_media.yml b/config/sync/views.view.missing_media.yml
index 5e49835..74f0a2e 100644
--- a/config/sync/views.view.missing_media.yml
+++ b/config/sync/views.view.missing_media.yml
@@ -1120,10 +1120,9 @@ display:
           separator: ', '
           field_api_classes: false
       pager:
-        type: some
+        type: none
         options:
           offset: 0
-          items_per_page: 0
       filters:
         islandora_has_media:
           id: islandora_has_media
aOelschlager commented 5 months ago

Sorry @rosiel I couldn't get the merge to work in the workspace so I had to use the suggested edit thing instead.