Islandora-Devops / islandora-starter-site

A Drupal site demonstrating Islandora features. Use it as a starting point for customization.
https://sandbox.islandora.ca
GNU General Public License v2.0
3 stars 17 forks source link

[BUG] Exported configs differ on Playbook and ISLE. #17

Open rosiel opened 1 year ago

rosiel commented 1 year ago

Overview

Playbook and ISLE provide external services that Drupal uses, and their locations (from Drupal's perspective) are configured in configuration entities that are part of the starter site. Example:

ISLE: broker is at tcp://activemq:61613 Playbook: broker is at tcp://127.0.0.1:61613

The Starter Site happens to contain values that match the Playbook, and ISLE includes a code that configures Drupal to point to the services at the ISLE locations. This is not a problem.

However when someone on ISLE wishes to make a PR against the Starter Site. When they do a config:export and git diff, the changes include these changed values. This makes it very hard to encourage people to do pull requests.

I have a document outlining what I think are the available options for this. To summarize it, I think we should duly consider:

rosiel commented 1 year ago

For current convenience, I wrote a shell script to change ISLE values back to Playbook values. It works on my mac. I don't know how to make it portable, sorry.

rosiel commented 1 year ago

As brought up by @Natkeeran , this is still an issue. I propose that we solve the immediate problem which is:

So I propose this which is not a tech solution, but I prefer it because it keeps things simpler and consistent: