Islandora-Devops / isle-buildkit

Provides a number of Docker images which can be used to build an Islandora site. See also https://github.com/Islandora-Devops/isle-dc
https://www.islandora.ca/
MIT License
13 stars 23 forks source link

Using Private Dockerhub & Attempting to change Github Actions vars.repository value doesn't result in changes? #314

Closed g7morris closed 10 months ago

g7morris commented 11 months ago

Hi @nigelgbanks

I'm attempting to build Docker images from our own forked isle-buildkit project that will push to our own private Dockerhub registry.

Screenshot 2023-12-05 at 2 11 25 PM

I'm still pushing the base image to the islandora Dockerhub registry which isn't ideal.

Did I miss any isle-buildkit documentation on how folks can do this but still stay at parity with isle-buildkit when submitting changes or do we need to build the ability to switch to non-Islandora repos and registries?

Thanks!

g7morris commented 11 months ago

I'll note that it appears even if I edit the .env file in the codebase, new images are run and pushed to the islandora Dockerhub.

I also note that https://github.com/Islandora-Devops/isle-buildkit/blob/main/.github/workflows/description.yml#L26 seems to have hardcoded values too? Do we want to change this to a variable instead?

nigelgbanks commented 11 months ago

We could change it such that REPOSITORY is set before calling make in https://github.com/Islandora-Devops/isle-buildkit/blob/171ae20200b2aebabd3e267748e87371fa6eb8cf/.github/workflows/build.yml#L56.

Also, for the descriptions, we could use the ${{ vars.repository }}.

Which I think covers the bases.

Though I'd probably say doing a fork is probably a waste of time. If you need to do customizations, extend the existing images and modify them. Your build times will be significantly faster, you'll have less code to maintain, and upgrades will be easier.

g7morris commented 11 months ago

Ah fair play. It would be nice to see those changes go in though just in case. Is that something you can push please?

In the meantime, I appreciate your comment here:

If you need to do customizations, extend the existing images and modify them

I'll start focusing on that route and see what dividends pay out. Cheers @nigelgbanks !

nigelgbanks commented 11 months ago

Oh yeah, these changes can go through. I'll push something up now.

nigelgbanks commented 11 months ago

https://github.com/Islandora-Devops/isle-buildkit/pull/316

nigelgbanks commented 11 months ago

@g7morris rebase from main and let me know if the recent changes sort the issue for you.

g7morris commented 11 months ago

Thank you!