search

Islandora-Devops / isle-buildkit

Provides a number of Docker images which can be used to build an Islandora site. See also https://github.com/Islandora-Devops/isle-dc
https://www.islandora.ca/
MIT License
13 stars 23 forks source link

Being able to set CORS with a .env variable would be nice #333

Closed noahwsmith closed 3 months ago

noahwsmith commented 3 months ago

To support inter-institutional collaboration, sometimes setting non-default values for CORS is necessary. Currently to do this requires bindmounting a copy of https://github.com/Islandora-Devops/isle-buildkit/blob/main/drupal/rootfs/etc/confd/templates/drupal.fpm.conf.tmpl and inserting into that template.

I believe that this is enough of a "standard use case" that we should support it with a .env variable. I will issue a PR momentarily to address this.

noahwsmith commented 3 months ago

What I've done is the VERY SIMPLE version that lets you set a single domain, or *. We could also look at a more complex situation where you pass in a regex that sets a list of allowed domains since you cannot just give it a list in string format. For example: https://github.com/kubernetes/ingress-nginx/issues/5496

noahwsmith commented 3 months ago

See comment in https://github.com/Islandora-Devops/isle-buildkit/pull/334 for alternate solution inside of Drupal.