hard code site root - Githubissues

Islandora-Devops / isle-buildkit

Provides a number of Docker images which can be used to build an Islandora site. See also https://github.com/Islandora-Devops/isle-dc

https://www.islandora.ca/

MIT License

13 stars 23 forks source link

hard code site root #349

Closed joshdentremont closed 1 month ago

joshdentremont commented 1 month ago

This should fix the issue introduced by drush 13 that stopped us from running certain drush commands before the site was installed. See https://github.com/Islandora-Devops/isle-site-template/pull/58 for more details.

AFAIK the drupal root is always the same when running buildkit in either Isle-dc or site template so this should be fine.

To test:

build the drupal image in this PR with docker buildx bake drupal
create a new site with Site Template as normal
change the Dockerfile in Isle Site Template to say FROM islandora/drupal:local so that it builds from this image
build a new Drupal image in the site template
spin up site using docker compose --profile dev up -d as normal

aOelschlager commented 1 month ago

I would add that there are other places where drupal:directory is referenced in the utilities.sh script that should be changed as well, in particular the update_settings_php that broke the isle-dc installation (has had fix with this pr)

Could the calls made to the drupal:directory be replaced with an environment variable instead?

joshdentremont commented 1 month ago

That drush command works once the site is installed, so everything else seems fine on my site template test so far.

Not sure about isle-dc, though. If it tries to run update_settings_php before doing a site install then it would likely fail, but I would think that should only run on installed sites.

nigelgbanks commented 1 month ago

I would add that there are other places where drupal:directory is referenced in the utilities.sh script that should be changed as well, in particular the update_settings_php that broke the isle-dc installation (has had fix with this pr)

Could the calls made to the drupal:directory be replaced with an environment variable instead?

There is an open issue to deprecate that whole file.

https://github.com/Islandora-Devops/isle-buildkit/issues/260

nigelgbanks commented 1 month ago

The others need to be changed as well... https://github.com/Islandora-Devops/isle-buildkit/pull/350 has the required changes along with a few other bugs I found while looking into this.