search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
22 stars 60 forks source link

Make local and make demo need to be updated to use Islandora 2.x #192

Closed noahwsmith closed 4 months ago

noahwsmith commented 2 years ago

From @rosiel

there seems to be no way to use isle to get the latest islandora code, since we’re on 2.x now. Can someone help me to update the composer files where they need to be adjusted? Thanks!

kayakr commented 2 years ago

The current demo (isle-dc release islandora/drupal:1.0.0-alpha-11) installs Drupal 8.9, that is EOL from 2 November 2021. Per @rosiel's question it's not clear how to update the demo codebase.

docker-compose exec -T drupal with-contenv bash -lc 'cat composer.json' shows the requested drupal core, e.g. "drupal/core": "^8.9"

This should be updated to drupal/core-recommended:^9.3 or similar.

I'm only guessing here, but does the isle-buildkit demo Dockerfile need to be updated to a new COMMIT hash? https://github.com/Islandora-Devops/isle-buildkit/blob/main/demo/Dockerfile

Should isle-dc demo continue to rely on https://github.com/dannylamb/islandora-sandbox or switch to https://github.com/Islandora-Devops/islandora-sandbox?

(Edited to add that https://github.com/dannylamb/islandora-sandbox redirects to https://github.com/Islandora-Devops/islandora-sandbox but presumably demo/Dockerfile should be updated anyway.)

rosiel commented 2 years ago

Merging #160 will solve some of this, including changing where the composer requirements are defined (https://github.com/Islandora-Devops/islandora_install_profile_demo/blob/main/composer.json). However, there's still a lock file upstream, in the islandora-sandbox, and we need a way to keep that up to date.

BTW, were you able to recently use make demo to install the old Drupal 8.9 site? I thought that pathway had been broken for a while.

kayakr commented 2 years ago

BTW, were you able to recently use make demo to install the old Drupal 8.9 site? I thought that pathway had been broken for a while.

Yes, make demo worked for me last night. I manually changed .env to specify TAG=1.0.0-alpha-11. Transcript of buiild attached. isle-dc-make-demo-transcript-alpha11-20220210.txt I haven't tested much yet. Beyond Drupal core 8.x being unsupported, other modules/versions like Automatic Entity Label, Devel, Entity Embed, Facets, are unsupported or need security updates.

joecorall commented 4 months ago

The make (demo|local) command has been replaced by documentation.

$ make demo
make demo has been removed. To create a demo site, please follow the instructions at https://islandora.github.io/documentation/installation/docker-local/