search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

Matomo configured with wrong site id #314

Open rosiel opened 2 years ago

rosiel commented 2 years ago

On TAG=1.0.10, ENVIRONMENT=starter_dev, Matomo is getting configured with site id = 2, but Drupal thinks site id = 1.

When I load Matomo's UI, it displays a "no data has been recorded yet, set up below" page. It specifies that the site ID expected is 2. However Drupal's Matomo configuration has it at 1.

Matomo's 'no data has been recorded' page

I'm currently spinning up make local to see if this happens there too.

jefferya commented 2 years ago

I can reproduce on non isle-dc site using isle-buildkit TAG 1.0.7.

Is the proper value 2 or 1? I suspect the 2 in Matomo is from isle-buildkit during the matomo database creation, more specifically,

https://github.com/Islandora-Devops/isle-buildkit/blob/main/matomo/rootfs/etc/matomo/create-matomo-database.sql#L878

) ENGINE=InnoDB AUTO_INCREMENT=2 DEFAULT CHARSET=utf8;

I've not found the time to dig deeper and test but the reasoning behind AUTO_INCREMENT=2 instead of 1 is not clear to me.

rosiel commented 2 years ago

Confirmed, it's happening on ISLE-DC with the local configuration as well.

noahwsmith commented 1 year ago

@nigelgbanks do you recall if that AUTO_INCREMENT=2 was intentional? Seems maybe like a bug/typo to me...

nigelgbanks commented 1 year ago

I can't remember, looks like @dannylamb added it here: https://github.com/Islandora-Devops/isle-buildkit/commit/544b045a26d62015761543b4a932516bba2ef81f#r93147610. Do you recall @dannylamb?

dannylamb commented 1 year ago

For the life of me I can't remember why it was bumped from 1 to 2. I think it was just not working and for whatever reason, bumping it to two made it work. But now the shoe appears to be on the foot so I dunno :sweat_smile:

rosiel commented 1 year ago

OK, so. In the Tech call today Seth also mentioned doing something about this - like needing to set autoincrement=2. We'll broaden this issue out to:

Install Profile: Use site_id = 2 in configs. Starter Site: same. Playbook: Get Matomo set up with autoincrement 2.

nigelgbanks commented 1 year ago

I should mention in upgrading Matomo for the 2.z release I've changed the way it installs such that we no longer need to create tables in this way, so hopefully the issue will not be present in the 2.X release.