This PR adds the DRUPAL_DEFAULT_DB_HOST and DRUPAL_DEFAULT_DB_PORT environment variables to the Drupal container when using mariadb.
Previously these were populated when the container spins up, as described in the README for Drupal and the base image:
"The default value is derived from DB_DRIVER if not specified"
This caused an issue for me where running make up would wait 10 seconds then run make update-settings-php but those values had not been derived yet. This caused my settings.php file to be populated correctly, except for
If I changed the wait from 10 to 30 seconds it would work, but by specifying it in the docker-compose file it removes the risk of these being blank because they are now specified as environment variables when starting the container.
This might be hard to test, because it only happened to me on a production environment where settings.php is created when the site is spun up and is not part of the image. It should be easy to test that it doesn't hurt anything though.
This PR adds the DRUPAL_DEFAULT_DB_HOST and DRUPAL_DEFAULT_DB_PORT environment variables to the Drupal container when using mariadb.
Previously these were populated when the container spins up, as described in the README for Drupal and the base image: "The default value is derived from
DB_DRIVERif not specified"This caused an issue for me where running
make upwould wait 10 seconds then runmake update-settings-phpbut those values had not been derived yet. This caused my settings.php file to be populated correctly, except forwhich were both blank.
If I changed the wait from 10 to 30 seconds it would work, but by specifying it in the docker-compose file it removes the risk of these being blank because they are now specified as environment variables when starting the container.
This might be hard to test, because it only happened to me on a production environment where settings.php is created when the site is spun up and is not part of the image. It should be easy to test that it doesn't hurt anything though.