search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
22 stars 60 forks source link

The drupal.Dockerfile still using registry.gitlab.com/nikathone/drupal-docker-good-defaults/php-nginx:latest for php and nginx base image #34

Closed g7morris closed 4 years ago

g7morris commented 4 years ago

Per @nikathone's comment here https://github.com/Islandora-Devops/isle-dc/pull/6

"The drupal.Dockerfile still using registry.gitlab.com/nikathone/drupal-docker-good-defaults/php-nginx:latest for php and nginx base image but this will change once we have a CI to build images/nginx-php/Dockerfile."

@nikathone Can we make an official Islandora version of this post-merge? We now have control over the Islandora Dockerhub account to be able to push images. We can also make a new repo accordingly if need be too. Your thoughts?

g7morris commented 4 years ago

@dannylamb Have you made a new Github repo and Dockerhub image from this?

dannylamb commented 4 years ago

Yeah, I can update that. I'm rocking the new repo now in my fork and everything works fine.