Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

Update make build to specify platform #345

Closed joshdentremont closed 1 year ago

joshdentremont commented 1 year ago

When building on an M1/M2 mac the default is to build for arm64 instead of amd64 which causes issues when trying to run a custom drupal image.

This PR specifies the image so that make build can be run on an M1/M2 mac.

To test, run make build to create a custom drupal image, then test that the image doesn't throw errors when starting. Without this PR on an M1/M2 mac the drupal container will continually restart.

joecorall commented 1 year ago

Should this just be an entry in sample.env?

DOCKER_DEFAULT_PLATFORM=linux/amd64
joshdentremont commented 1 year ago

@joecorall we could put this in an environment variable, but I don't think the image works with anything other than linux/amd64. When I tried building with the default on my M2 it was giving me errors during startup, so I suspect that the Islandora Drupal image only supports amd