search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

remove recast #346

Closed joecorall closed 1 year ago

joecorall commented 1 year ago

Closes https://github.com/Islandora-Devops/isle-dc/issues/299

make starter TAG=2.0.0 is failing with

Error response from daemon: manifest for islandora/recast:2.0.0 not found: manifest unknown: manifest unknown

See https://github.com/Islandora-Devops/isle-buildkit/issues/220 for additional discussion around removing recast. It was removed from isle-buildkit with https://github.com/Islandora-Devops/isle-buildkit/pull/238

With this PR make starter TAG=2.0.0 builds OK.

DonRichards commented 1 year ago

I'm getting the following error with this PR.

make starter-finalize ENVIRONMENT=starter
make[1]: Entering directory '/Users/admin/isle-dc'
docker compose exec -T drupal with-contenv bash -lc 'chown -R nginx:nginx .'
make drupal-database update-settings-php
make[2]: Entering directory '/Users/admin/isle-dc'
make[2]: Leaving directory '/Users/admin/isle-dc'
make[2]: *** [Makefile:528: drupal-database] Error 143
make[1]: *** [Makefile:577: starter-finalize] Error 2
make[1]: Leaving directory '/Users/admin/isle-dc'
make: *** [Makefile:173: starter] Error 2
joecorall commented 1 year ago

@DonRichards that's fixed with https://github.com/Islandora-Devops/isle-dc/pull/347

That issue is related to the version of PHP running in the drupal container, and not an issue with removing recast.

DonRichards commented 1 year ago

Brought this up in the tech call. And since this works with make local we came to the conclusion this works and can be merged.