search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

Update traefik version #359

Closed joshdentremont closed 1 year ago

joshdentremont commented 1 year ago

updated version of Traefik to match the version that site template uses.

g7morris commented 1 year ago

Quick question of why aren't we attempting to use the latest version of traefik of 2.10.4 ? Did someone test and that didn't work?

Or does this traefik value in the isle-site-template also need to be upgraded first and then this project?

Just curious what the order of ops is here?

Should we work with @nigelgbanks on this too?

g7morris commented 1 year ago

Just an FYI, tested running with latest 2.10.4 on an existing site with no ill effects. More extensive testing warranted.

joshdentremont commented 1 year ago

@g7morris That's a good question. I just used the same one as the site template because I figured that was what was tested with Buildkit.

I would be happy to bump it up, but I think we should probably keep Isle and Site Template on the same version, so we should bump both at the same time.

nigelgbanks commented 1 year ago

No need to sync with isle-site-template. The version used in the site template was just the latest available at the time it was written, I think. There isn't any real need to test with isle-buildkit releases, either. The only concern with traefik is the Docker labels used in the docker-compose.yml files. Since isle-site-template and isle-dc have different docker-compose.yml files, there isn't any need to keep them in sync.

joshdentremont commented 1 year ago

Updated this to use the newest version, 2.10.5