search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

Updated network option #381

Closed ajstanley closed 7 months ago

ajstanley commented 8 months ago

This relates to issue 379. External is not a recognized Docker network option, but it only fails on some machines. This ought to work anywhere, but its only been tested on a Mac, and an old one at that,

misilot commented 8 months ago

That's weird since external is defined in the documentation: https://docs.docker.com/compose/compose-file/06-networks/#external

misilot commented 8 months ago

Though it looks like the default is internal: false so would it be worth removing that config option all together?

aOelschlager commented 8 months ago

I would agree with @misilot that internal:false can be removed from the yaml files. In the tech call it was mentioned that the original purpose for this (external:true) was to be able to run isle 7 at the same time as isle-dc. I don't know if anyone is using it this way anymore but I highly doubt it.