Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

How to docker-compose down the containers started by running "make starter"? #388

Closed fishfree closed 5 months ago

fishfree commented 5 months ago

I don't find where is the docker-compose.yml generated by the make startercommand.

DonRichards commented 5 months ago

@fishfree In the Makefile it's calling this in multiple places but default runs with every make command. But here is where it's being actually constructed https://github.com/Islandora-Devops/isle-dc/blob/development/Makefile#L252.

In a nutshell

docker compose $(SERVICES:%=-f build/docker-compose/docker-compose.%.yml) config

Docker compose is looking at the build/docker-compose/ directory and merges all of the YML files that use naming convention docker-compose.*.yml.

fishfree commented 5 months ago

@DonRichards Thank you! So I need to docker-compose down every yaml file in the folder build/docker-compose?

highermath commented 5 months ago

Won't make down work for you?

On Sat, Apr 27, 2024 at 5:47 PM fishfree @.***> wrote:

@DonRichards https://github.com/DonRichards Thank you! So I need to docker-compose down every yaml file in the folder build/docker-compose?

— Reply to this email directly, view it on GitHub https://github.com/Islandora-Devops/isle-dc/issues/388#issuecomment-2081268369, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACIAMLGKPJZ2I4X6UZB4SDY7RBL3AVCNFSM6AAAAABGWHHYJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGI3DQMZWHE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Cary Gordon lechienlunatique.com https://us-east-1.console.aws.amazon.com/route53/domains/home?region=us-east-1#/DomainDetails/lechienlunatique.com 818-694-1626 (mobile)

DonRichards commented 5 months ago

@highermath You're correct. make down runs the docker compose down against the compiled docker-compose.yml.

@fishfree No, you just run it against the docker-compose.yml file if you don't want to run the make down command.

fishfree commented 5 months ago

@highermath @DonRichards Thank you! make down works!