search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
23 stars 60 forks source link

Update how settings.php gets appended #403

Closed aOelschlager closed 3 months ago

aOelschlager commented 3 months ago

For issue https://github.com/Islandora-Devops/isle-dc/issues/401

This removes the update-settings make command from the starter variants and replaces the default_settings.txt in the starter site. This is how the isle site template does it's configuration.

To test run make starter_dev or make starter.

aOelschlager commented 3 months ago

Make starter_dev works but make starter errors out.

alxp commented 3 months ago

Confirm that make starter_dev works for me.

make starter seems to fail on Drupal install looking for the database, but I was able to immediately docker compose exec mariadb with-contenv bash and run mysql and see the database was created. Running make starter again continues the build. So I don't think the error is related to the problem addressed in this PR>

aOelschlager commented 3 months ago

That fixed the error on make starter. This works but it's still calling the update-settings make command during make hydrate. If I remove that command from make hydrate then make starter and make starter_dev white screen on adding repository objects or media. I think it has to do with the fedora url not being set. I should have that fixed here soon.

aOelschlager commented 3 months ago

This is ready for review now.