search

Islandora-Devops / isle-dc

ISLE 8 - Dockerized Islandora 8 Deployment orchestrated with docker-compose
MIT License
22 stars 60 forks source link

Review Docker Images& Services for S6 inclusion #61

Closed g7morris closed 4 years ago

g7morris commented 4 years ago

From the April 23 weekly call, @nigelgbanks raised the idea of discussing potentially using s6-overlay for

The task should be to identify which images and services could benefit from utilizing s6-overlay to help with process management especially child processes handling as well as piping logs to stdout (as needed)

Also reference this issue: Logging to stderr / stdout for all images / containers / services #45

dannylamb commented 4 years ago

I'm looking over the stack right now and seeing blank spots in config files in the pre-built images. We're envsubsting in the build process, and args aren't getting set right. But that stuff probably shouldn't be in the build process anyway and we should use confd to template it out in the entrypoint.

If I'm gonna go as far as to do that, we should consider the whole s6/confd combo as an under-layer. Off the top of my head, it'd be applicable to

And probably more, but that's the containers I'm familiar with.

I'm comfortable enough to attempt installing confd and trying my hand at that, but s6 I would just be blindly flailing about. Help with that would be appreciated.

nigelgbanks commented 4 years ago

Sorry for dropping off the radar and not posting sooner, when I went to do some cleanup on what I had locally over the weekend I ended up just spending the whole weekend on it. It's close to be done, but in the process of trying to tidy what I had I broke it. The general idea and layout is there but there are lots of bugs and things that need doing to make it work fully, I think about 2-3 days of work to get it in a good place.

https://github.com/nigelgbanks/docker-experiment

dannylamb commented 4 years ago

Oh snap you've got everything. Yeah i'm sure it'll need to get looked over thoroughly as it gets wired up. That's where our current implementation is at.

I'll take a deeper look :eyes: Thanks for dropping it off.

g7morris commented 4 years ago

As agreed on the weekly tech call, @nigelgbanks to give working demo for May 14th call for team review. Thanks @nigelgbanks for doing this. :+1:

g7morris commented 4 years ago

This work is now being done here https://github.com/Islandora-Devops/isle-buildkit. Closing ticket.