search

Islandora-Devops / isle-site-template

Template for building and customising your institution's Islandora installation.
MIT License
5 stars 6 forks source link

Add support for wildcard certificates #19

Closed joecorall closed 1 year ago

joecorall commented 1 year ago

For sites that might utilize a wildcard TLS certificate, having the fcrepo/activemq/etc. domains be children of the drupal domain will not allow the same wildcard certificate to be used. This PR makes those subdomains the same level as the drupal domain, while keeping the default the way it was before.

Would be ideal if - could simply replace . as the subdomain delimiter, but opted to send this PR to support both in case . is a hard requirement for some use cases.

joecorall commented 1 year ago

Makes sense re complexity.

Though just for clarification:

That being said, in the use case you outline, you are not actually using a wildcard certificate for *.islandora.library.world.com

It is *.islandora.library.world.com for activemq/fcrepo/etc. in the production profile: https://github.com/Islandora-Devops/isle-site-template/blob/afa3e82d7fec510c31f17c5788e024ce8c087cc9/docker-compose.yml#L675-L683