Islandora-Devops / isle-site-template

Template for building and customising your institution's Islandora installation.
MIT License
6 stars 5 forks source link

Add drush path for Drush 12/Drupal 10. #9

Closed rosiel closed 11 months ago

rosiel commented 11 months ago

I followed some instructions online to add the path to drush (and other vendored binaries) in the Dockerfile.

Solves https://github.com/Islandora-Devops/isle-buildkit/issues/283.

@Islandora-Devops/committers

rosiel commented 11 months ago

Oh no! On further investigation with @aOelschlager it should probably be done in buildkit.

rosiel commented 11 months ago

Rather, it appears buildkit installs drush via the no-longer-supported drush-launcher in drupal/Dockerfile. It's also doing so with version 0.6.0 which is ~3y old.

On the other hand, both the starter site and the install profile (retro compatibility but ok for now) require drush/drush in their composer.json files. This implies to me that drush should, for those two install methods, resolve at /var/www/drupal/vendor/bin/drush. I propose we lean into this, by:

rosiel commented 11 months ago

Maybe we can merge this PR as a temporary fix since our main build method is currently broken, and then as part of a larger initiative, investigate how we install drush/drush launcher in buildkit?