search

Islandora-Labs / islandora_solr_collection_view

This replaces the browse display provided by Islandora collection objects with a View, providing enhanced customization and performance.
http://islandora.ca/
GNU General Public License v3.0
3 stars 4 forks source link

Make 'Islandora Solr: TN Image' field themable #11

Closed mjordan closed 8 years ago

mjordan commented 8 years ago

The IslandoraSolrCollectionViewHandlerTN handler returns hard-coded HTML:

return ('<img src="/islandora/object/' . $pid . '/datastream/TN/view" />');

whereas is should return the output of a theming function like the IslandoraSolrCollectionViewHandlerTeaser handler does:

return theme('islandora_solr_teaser', array('values' => $values));

mjordan commented 8 years ago

PR is not showing up automatically, but it's at https://github.com/Islandora-Labs/islandora_solr_collection_view/pull/12.

mjordan commented 8 years ago

Thanks very much for review and merging @rosiel, I'll close this issue.