Who may merge sole maintainer's PRs?

Islandora-Labs / islandora_solr_collection_view

This replaces the browse display provided by Islandora collection objects with a View, providing enhanced customization and performance.

http://islandora.ca/

GNU General Public License v3.0

3 stars 4 forks source link

Who may merge sole maintainer's PRs? #17

Closed mjordan closed 7 years ago

mjordan commented 7 years ago

@rosiel sorry I didn't catch this earlier, but the CONTRIBUTING.md says:

Only maintainers of this module may merge pull requests.
A maintainer may merge anyone's pull requests (except their own)

But if there is only one maintainer as is the case now (Hi! 😄), who is able to merge PRs that the maintainer opens?

rosiel commented 7 years ago

Hi! Um. Well yes that is a problem!

Is "(including their own)" ok?

Also, I can co-maintain if you like.

mjordan commented 7 years ago

I'd say including their own is OK, and sure, it'd be great to have a co-maintainer! I can take care of this change over the weekend if you want.

manez commented 7 years ago

It's like a GitHub Barber Paradox 😄

What about "The maintainer(s) of this module and any Islandora Committer may merge pull requests," so you have at least as many potential mergers as the old way, plus maintainers?

mjordan commented 7 years ago

Thanks @rosiel!

mjordan commented 7 years ago

@manez I don't have permission to change settings on this repo. Can you set it so that people can merge approve/merge their own PRs?

manez commented 7 years ago

@mjordan I think I have it turned off now, for administrators only (which would be maintainers and Committers)