Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface

GNU General Public License v3.0

13 stars 23 forks source link

Issue 107 #108

Closed MarcusBarnes closed 7 years ago

MarcusBarnes commented 7 years ago

What does this Pull Request do?

Travis-CI build was failing for PHP 5.3.3 because of change to default trusty distribution and use of unsupported array syntax in VttConverter.php. Addresses issue https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/issues/107.

What's new?

Uses a build matrix in the .travis.yml file. Note that http://lint.travis-ci.org/ reports a problem with the use of dist, but this is a known issue.
- Comments-out notifications to the Islandora IRC channel in .travis.yml as we've been testing the build a lot.
- Uses array() syntax in rather than [] for array initialization in VttConverter.php for backwards compatibility with PHP 5.3.3.

How should this be tested?

On submitting the pull-request, wait for Travis-ci to complete the build. The build should be successful.

Additional Notes:

Thanks to @witt for pointing out the typo noted in issue https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/issues/105 which brought the Travis-ci build problem to our attention.

Interested parties

@Natkeeran