search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Web Annotation Search and Oral Histories - pop-up appears even when not navigating to annotation from Solr search. #117

Closed MarcusBarnes closed 6 years ago

MarcusBarnes commented 6 years ago

This issue is related to those who use both the Oral Histories Solution Pack and the Web Annotation Utility module on the same Islandora instance. The following merged pull-request https://github.com/digitalutsc/islandora_web_annotations/pull/242 introduced a way of skipping to video (audio) annotations directly from search (related to issue https://github.com/digitalutsc/islandora_web_annotations/issues/186). As part of this process, the user is presented with a message to proceed to the annotation or not. When this commit (and relevant Solr Search commit) are installed on an Islandora instance with Oral Histories, this pup-up appears whenever an Oral History object is loaded from the repository.

The expected behavior is to see this pop-up when navigating to a specific annotation on an oral history object from the Solr Search results, and not to see the pop-up when simply navigating to a particular oral history object from the standard Islandora repository view.

This issue may be best fixed via the JavaScript in Web Annotations, but I'm noting it here so that the issue is documented.

MarcusBarnes commented 6 years ago

There is a pull-request in Web Annotations to address this issue. Once merged, please confirm that it addresses the issue observed here adequately and close as appropriate.

MarcusBarnes commented 6 years ago

Addressed in the merged Web Annotations pull-request https://github.com/digitalutsc/islandora_web_annotations/pull/244 (commit https://github.com/digitalutsc/islandora_web_annotations/commit/23fb5e36badeb3f52a76cfa76a2e50930921cc2d).