search

Islandora-Labs / islandora_solution_pack_oralhistories

Adds all required Fedora objects to allow users to ingest and retrieve Oral Histories (video/audio) files through the Islandora interface
GNU General Public License v3.0
13 stars 23 forks source link

Add isset checks to certain params in template. #122

Closed ryanbrinn closed 6 years ago

ryanbrinn commented 6 years ago

Template files are making assumptions about present datastrams that are violated by running derivatives in separate processes, as is done with gearman. Example: Notice: Undefined index: tn in include() (line 5 of /var/www/drupal7/sites/all/modules/islandora_solution_pack_oralhistories/theme/islandora-html5-video-stack.tpl.php). Notice: Undefined index: url in include() (line 6 of /var/www/drupal7/sites/all/modules/islandora_solution_pack_oralhistories/theme/islandora-html5-video-stack.tpl.php). Notice: Undefined index: mime in include() (line 6 of /var/www/drupal7/sites/all/modules/islandora_solution_pack_oralhistories/theme/islandora-html5-video-stack.tpl.php).

I've created a pull here: https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/pull/121 which will add an isset check to the affected params so it will fail gracefully.

MarcusBarnes commented 6 years ago

Addressed in pull-request https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/pull/121 (merged with commit https://github.com/Islandora-Labs/islandora_solution_pack_oralhistories/commit/f586562418bbc3545957a453ce6315a098d373de). Thank you @ryanbrinn for your contribution.